Skip to content

adding Invoke-AzVmAssessPatch cmdlet. #12608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

adding Invoke-AzVmAssessPatch cmdlet. #12608

wants to merge 8 commits into from

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Aug 7, 2020 •
edited by isra-fel
Loading

Description

adding Invoke-AzVmAssessPatch cmdlet.

And also updated computecommontest to not have space in the location return for Get-ComputeVmLocation
and added a function that will return an available sku for given subscription, location, and resourcetype.

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/634

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Aug 7, 2020

Can one of the admins verify this patch?

@isra-fel isra-fel self-assigned this Aug 10, 2020
isra-fel
isra-fel reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @grizzlytheodore , I know this PR has passes design review, but the name Invoke-AzVmAssessPatch might be a little bit misleading. Putting the word "Patch" at the end makes it sound like invoking a patch to me, however what the command actually does it to invoke an assessment, right?

So I suggest Invoke-AzVmPatchAssess or Invoke-AzVmPatchAssessment. To be frank, Get-AzVmPatch could be even better because it describes the nature of the function accurately and simply.

Let me know what you think. Thanks.

cc @VeryEarly

@grizzlytheodore grizzlytheodore deleted the invokeAzPatch branch August 12, 2020 19:46
@grizzlytheodore grizzlytheodore mentioned this pull request Aug 12, 2020
Merged
8 tasks
@grizzlytheodore
Copy link
Contributor Author

grizzlytheodore commented Aug 12, 2020

moved to #12658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel left review comments

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@grizzlytheodore grizzlytheodore

@isra-fel isra-fel

Labels

Discuss needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grizzlytheodore @adxsdkps @isra-fel @azuresdkci